build: fetch Boost from OSS and define network test macro globally#438
Open
zjw1111 wants to merge 2 commits into
Open
build: fetch Boost from OSS and define network test macro globally#438zjw1111 wants to merge 2 commits into
zjw1111 wants to merge 2 commits into
Conversation
zjw1111
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fetch the pinned Boost 1.66.0 source package from Paimon C++ OSS instead of storing the 85 MiB archive in Git LFS.
The dependency resolution follows the Lumina pattern:
PAIMON_BOOST_URLoverrides the source, a pre-downloaded package underthird_party/supports offline builds, and OSS is the default fallback. The OSS object has the same SHA256 checksum as the removed vendored archive.The obsolete Boost entries in the repository
LICENSEandNOTICEare removed because the repository no longer redistributes Boost source code.Define
PAIMON_ENABLE_NETWORK_TESTSglobally in the root CMake configuration and remove the duplicate target-level definitions from the filesystem and integration test targets. The option no longer requiresPAIMON_BUILD_TESTS=ON; when tests are disabled, the definition is harmless because no test targets are built.Tests
cmake -S . -B /tmp/paimon-boost-config.OiysFH -DCMAKE_BUILD_TYPE=Debug -DPAIMON_BUILD_TESTS=OFF -DPAIMON_ENABLE_AVRO=OFF -DPAIMON_ENABLE_ORC=OFF -DPAIMON_ENABLE_LANCE=OFF -DPAIMON_ENABLE_JINDO=OFF -DPAIMON_ENABLE_LUMINA=OFF -DPAIMON_ENABLE_LUCENE=ON -DPAIMON_ENABLE_TANTIVY=OFFcmake --build /tmp/paimon-boost-config.OiysFH --target boost_ep -j64PAIMON_BUILD_TESTS=ONandPAIMON_ENABLE_NETWORK_TESTS=ON; verified the generated compile commands definePAIMON_ENABLE_NETWORK_TESTSfor both filesystem and integration tests.PAIMON_BUILD_TESTS=OFFandPAIMON_ENABLE_NETWORK_TESTS=ON; verified configuration succeeds with the global definition.pre-commit run --files LICENSE NOTICE cmake_modules/ThirdpartyToolchain.cmake third_party/versions.txtpre-commit run --files CMakeLists.txt src/paimon/CMakeLists.txt test/inte/CMakeLists.txtgit diff --checkAPI and Format
No public API, storage format, or protocol changes.
Documentation
No user-facing feature documentation is required.
Generative AI tooling
Generated-by: OpenAI Codex (GPT-5)